Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't crash on non-existent valueFrom path values #2140

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: Don't crash on non-existent valueFrom path values #2140

merged 1 commit into from
Aug 21, 2023

Conversation

chihshenghuang
Copy link
Contributor

@chihshenghuang chihshenghuang commented Aug 9, 2023 •
edited
Loading

What this PR does / why we need it:
This PR #1998 didn't fix the issue that kube-state-metrics will crash if the valueFrom path is non-exist. This issue is mentioned at #2141
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
No
Which issue(s) this PR fixes:
Fixes #1992

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 9, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: chihshenghuang / name: Chih-Sheng Huang (4433379)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @chihshenghuang!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2023
@chihshenghuang chihshenghuang marked this pull request as ready for review August 9, 2023 23:10
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 9, 2023
@chihshenghuang chihshenghuang mentioned this pull request Aug 10, 2023
Closed
@chihshenghuang chihshenghuang changed the title Don't crash on non-existent valueFrom path values fix: Don't crash on non-existent valueFrom path values Aug 10, 2023
@dashpole
Copy link
Contributor

/assign @dgrisonnet
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 10, 2023
dgrisonnet
dgrisonnet approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@rexagod could you please also have a look?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@rexagod
Copy link
Member

rexagod commented Aug 17, 2023

Right, my PR didn't fix it for fields that depended on path, such as valueFrom, but only the path itself. Only nit I'd suggest here is to reword the commit header and message since this doesn't seem to be a gauge-specific fix.

Thank you for this fix! 🙂

@chihshenghuang chihshenghuang force-pushed the fix-guage-value-func-panic branch from cc06755 to 4433379 Compare August 20, 2023 17:33
@chihshenghuang
Copy link
Contributor Author

Thanks @rexagod for the review and comment! I updated the commit message, please take a look again!

@rexagod
Copy link
Member

rexagod commented Aug 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chihshenghuang, dgrisonnet, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 60d4c4e into kubernetes:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrisonnet dgrisonnet dgrisonnet approved these changes

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dgrisonnet dgrisonnet

@rexagod rexagod

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash on nonexistent metric paths in custom resources
5 participants
@chihshenghuang @k8s-ci-robot @dashpole @rexagod @dgrisonnet